Fixes credit_card_fraud.exs example #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should make an effort to make this compatible with Explorer 0.5 instead of keeping it at Explorer 0.2, especially given how much has been changed/added |
grzuy
force-pushed
the
fix_credit_card_example
branch
from
966349d
to
35138bf
Compare
|
OK. I think I found a way to normalize data frame in a more concise and efficient way using latest So this PR, as of current implementation, is blocked on having an |
grzuy
commented
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems the example was written for
explorer 0.2and never adapted to support latest explorer?For now quick fix to go back to compatible explorer version.
Haven't had time to see which/how many updates necessary to make it work with explorer 0.5.
Thanks!
UPDATE:
Updated to adapt example code to latest explorer tip.
BLOCKED by explorer future release.
UPDATE 2:
explorer released.
This PR no longer Blocked.